Use FLASK_ADMIN_ prefix for all app.config configuration
#2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Flask app config option `FLASK_ADMIN_MAPBOX_MAP_ID` was required to enable map widgets, even if MapBox wasn't being used. Let's clear up this confusion by having a clearer config name for toggling maps on/off: `FLASK_ADMIN_MAPS`. And then finally update the documentation around maps to talk about this new configuration, and also talk about how to override the default MapBox integration. Finally, we update the geoalchemy example app to have some pages use the default MapBox integration and some use OSM instead.
samuelhwilliams
changed the title
FLASK_ADMIN_ prefix for all app.config configuration
18 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all of the Flask app configuration for Flask-Admin under the
FLASK_ADMIN_namespace/prefix, so that it's easier for users to group/identify.Also adds some light information about the configuration to our documentation.
We also address a confusion situation with maps:
Previously the Flask app config option
FLASK_ADMIN_MAPBOX_MAP_IDwasrequired to enable map widgets, even if MapBox wasn't being used.
Let's clear up this confusion by having a clearer config name for
toggling maps on/off:
FLASK_ADMIN_MAPS.And then finally update the documentation around maps to talk about this
new configuration, and also talk about how to override the default
MapBox integration.
Finally, we update the geoalchemy example app to have some pages use the
default MapBox integration and some use OSM instead.
fixes: #2034